Re: [PATCH v2 RESEND 07/18] x86, ACPI: Also initialize signature and length when parsing root table.

From: Rafael J. Wysocki
Date: Mon Aug 05 2013 - 09:18:29 EST


On Monday, August 05, 2013 09:33:32 AM Tang Chen wrote:
> Hi Rafael,
>
> On 08/02/2013 09:03 PM, Rafael J. Wysocki wrote:
> > On Friday, August 02, 2013 05:14:26 PM Tang Chen wrote:
> >> Besides the phys addr of the acpi tables, it will be very convenient if
> >> we also have the signature of each table in acpi_gbl_root_table_list at
> >> early time. We can find SRAT easily by comparing the signature.
> >>
> >> This patch alse record signature and some other info in
> >> acpi_gbl_root_table_list at early time.
> >>
> >> Signed-off-by: Tang Chen<tangchen@xxxxxxxxxxxxxx>
> >> Reviewed-by: Zhang Yanfei<zhangyanfei@xxxxxxxxxxxxxx>
> >
> > The subject is misleading, as the change is in ACPICA and therefore affects not
> > only x86.
>
> OK, will change it.
>
> >
> > Also I think the same comments as for the other ACPICA patch is this series
> > applies: You shouldn't modify acpi_tbl_parse_root_table() in ways that would
> > require the other OSes using ACPICA to be modified.
> >
>
> Thank you for the reminding. Please refer to the attachment.
> How do you think of the idea from Zheng ?

It's doable and, quite frankly, if the ACPICA maintainers are happy, I'm fine
with that too.

Thanks,
Rafael


--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/