Re: [PATCH v7] watchdog: Add MOXA ART watchdog driver

From: Guenter Roeck
Date: Fri Aug 02 2013 - 12:39:54 EST

On 08/02/2013 04:41 AM, Mark Rutland wrote:
On Mon, Jul 29, 2013 at 01:33:48PM +0100, Jonas Jensen wrote:
Add watchdog driver for MOXA ART SoCs.

[ ... ]
+ err = watchdog_register_device(&moxart_wdt->dev);
+ if (unlikely(err))
+ return err;

This is a probe path. Is the use of unlikely() really appropriate here?
I suspect it doesn't make any appreciable difference, and should go.

Just wondering, for my education - why ? Is there s rule that unlikely()
shall not be used in the probe path ? If so, I would like to know it and
its reasoning to be able to apply it to my own reviews.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at