Re: [PATCH V2 3/3] ethernet: Convert mac address uses of 6 toETH_ALEN

From: Russell King - ARM Linux
Date: Thu Aug 01 2013 - 17:06:55 EST

On Thu, Aug 01, 2013 at 02:04:47PM -0700, Joe Perches wrote:
> On Thu, 2013-08-01 at 21:58 +0100, Russell King - ARM Linux wrote:
> > This seems rather obscure - I mean, it's not obvious to driver authors
> > that should be the case. Would it not be better to make this a little
> > more obvious somehow? Maybe __aligned(2) against mac_addr? Or
> > maybe have a debugging check for it?
> That'd be for David Miller (cc'd).
> I believe he's argued in the past that any alignment check
> for mac addresses was unnecessary.
> For all I know it really might not matter because pasemi
> can successfully dereference a ushort against an odd char
> pointer.
> I just noticed it and thought it'd be better moved.

As can ARM too for years now - either in hardware or via fixup for
kernel code.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at