Re: qlcnic binary sysfs file abuse

[David Miller]

From: Sony Chacko <sony.chacko@xxxxxxxxxx>
Date: Thu, 25 Jul 2013 19:37:46 +0000

>> -----Original Message-----
>> From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
>> Sent: Saturday, July 06, 2013 5:30 PM
>> To: Rajesh Borundia; Shahed Shaikh; Jitendra Kalsaria; Sony Chacko; Dept-Eng
>> Linux Driver
>> Cc: netdev; linux-kernel
>> Subject: qlcnic binary sysfs file abuse
>> 
>> I was doing a kernel-wide audit on all of the binary sysfs files, and noticed a
>> metric ton of them in the qlcnic driver.
>> 
>> So, any objection to me just deleting these entirely?  Or, if they really are
>> needed, can I just move them to debugfs, which is where I think they should
>> have been from the beginning?
> 
> Some applications are using these files, please move them to debugfs.

This is quite a mess, and I've complained about all of the crazy
files created by qlcnic in the past.

debugfs is for things that do not create a ABI which the kernel has to
maintain forever.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/