Re: [PATCH 2/4] msm_serial: Fix sparse warnings

[David Brown]

On Wed, Jul 24, 2013 at 11:37:29AM -0700, Stephen Boyd wrote:
> drivers/tty/serial/msm_serial.c:302:6: warning: symbol 'msm_set_mctrl' was
> not declared. Should it be static?
> drivers/tty/serial/msm_serial.c:597:17: warning: incorrect type in argument 2
> (different address spaces)
> drivers/tty/serial/msm_serial.c:597:17: expected void volatile [noderef] <asn:2>*addr
> drivers/tty/serial/msm_serial.c:597:17: got unsigned int *
> drivers/tty/serial/msm_serial.c:608:33: warning: incorrect type in argument 1
> (different address spaces)
> drivers/tty/serial/msm_serial.c:608:33: expected void volatile [noderef] <asn:2>*addr
> drivers/tty/serial/msm_serial.c:608:33: got unsigned int *gsbi_base
> drivers/tty/serial/msm_serial.c:648:37: warning: incorrect type in assignment
> (different address spaces)
> drivers/tty/serial/msm_serial.c:648:37: expected unsigned int *gsbi_base
> drivers/tty/serial/msm_serial.c:648:37: got void [noderef] <asn:2>*
>
> Mark the ioremapped memory as __iomem and use writel instead of
> iowrite because we're not dealing with PCI devices. Also, mark
> msm_set_mctrl() static because it isn't used outside this file.
>
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> ---
> drivers/tty/serial/msm_serial.c | 17 +++++++----------
> 1 file changed, 7 insertions(+), 10 deletions(-)

Acked-by: David Brown <davidb@xxxxxxxxxxxxxx>

--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/