Re: [char-misc-next 2/3] mei: adding sysfs fw_status attribute

From: Greg KH
Date: Wed Jul 24 2013 - 16:30:05 EST


On Wed, Jul 24, 2013 at 06:04:33PM +0000, Winkler, Tomas wrote:
>
>
> > >
> > > Just to make sure, is this what you're suggesting ?
> > >
> > > device->groups = mei_attr_groups
> > > mei_misc_device.parent = device;
> > > ret = misc_register(&mei_misc_device);
> >
> > Yes, that should work. If not, please let me know, the code underwent some
> > changes in 3.11-rc2.
>
> I don' t see the file being created.
> Not sure if the misc_register setup the parent sysfs as well.

Oops, wait, the parent is already registered, that's not going to work,
you want to create the files for the device itself that you are
creating, so set the ->groups field for that device.

sorry about that.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/