Re: [PATCH v2] power: Include additional information inpm_print_times

From: Greg KH
Date: Fri Jun 14 2013 - 16:40:03 EST


On Fri, Jun 14, 2013 at 02:35:24PM -0600, Shuah Khan wrote:
> Change __device_suspend() path to include driver name and the ops that
> get run for a device. This additional information helps associate the
> driver and the type of pm_ops the device uses in the suspend path very
> quickly which will aid in debugging problems in suspend and resume paths.
> Changed both start and end debug messages to include pm_ops information
> and use dev_info() instead of pr_info().
>
> dmesg output before the change:
>
> [ 164.390032] calling 1-1+ @ 69, parent: usb1
> [ 164.390035] call 1-1+ returned 0 after 0 usecs
>
> [ 164.390352] calling 00:0a+ @ 2457, parent: pnp0
> [ 164.390357] call 00:0a+ returned 0 after 3 usecs
>
> [ 164.390361] calling 00:09+ @ 2457, parent: pnp0
> [ 164.496458] call 00:09+ returned 0 after 103500 usecs
>
> [ 164.496494] calling 00:05+ @ 2457, parent: pnp0
> [ 164.496511] call 00:05+ returned 0 after 14 usecs
>
> dmesg output after the change:
>
> [ 58.707002] usb usb1: calling type pm ops @ 57, parent: 0000:00:1d.0
> [ 58.707641] usb usb1: call type pm ops returned 0 after 611 usecs
>
> [ 58.702014] system 00:0a: calling legacy bus pm ops @ 2173, parent: pnp0
> [ 58.702018] system 00:0a: call legacy bus pm ops returned 0 after 2 usecs
>
> [ 58.702023] tpm_tis 00:09: calling legacy bus pm ops @ 2173, parent: pnp0
> [ 58.806909] tpm_tis 00:09: call legacy bus pm ops returned 0 after 102425 usecs
>
> [ 58.806927] rtc_cmos 00:05: calling legacy bus pm ops @ 2173, parent: pnp0
> [ 58.806935] rtc_cmos 00:05: call legacy bus pm ops returned 0 after 5 usecs
>
> Signed-off-by: Shuah Khan <shuah.kh@xxxxxxxxxxx>
> ---
> drivers/base/power/main.c | 44 +++++++++++++++++++++++++-------------------
> 1 file changed, 25 insertions(+), 19 deletions(-)

I'm assuming this will go through Rafael's tree:

Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/