Re: [PATCH 01/22] mfd/ti_am335x_tscadc: remove regmap

From: Mark Brown
Date: Fri Jun 14 2013 - 09:54:41 EST

On Tue, Jun 11, 2013 at 04:34:53PM +0200, Sebastian Andrzej Siewior wrote:

> >> Therefore this patch removes regmap part of the driver.

> > NAK. Using regmap is better than open coding your register accesses, and
> > the children not using this API is not a reason for the MFD driver to do
> > the same.

> There is no advantage over using regmap in the first place. It goes
> through a few layers, uses no caching because almost all registers are
> volatile and this is a direct bus. In the end it complicates more than
> it helps.

It does give you tracepoints and debugfs. If it's making things at all
complicated we need to look at why that is and figure out how to fix
that since it's probably an issue for other users.

Attachment: signature.asc
Description: Digital signature