[PATCH] Drivers: hv: vmbus: incorrect device name is printed whenchild device is unregistered

From: Fernando Soto
Date: Thu Jun 13 2013 - 20:16:23 EST

From: Fernando Soto <fsoto@xxxxxxxxxxxxxxxxxxx>
Please CC me, I am not subscribed to the list.

Whenever a device is unregistered in vmbus_device_unregister (drivers/hv/vmbus_drv.c), the device name in the log message may contain garbage as the memory has already been freed by the time pr_info is called. Log example:
[ 3149.170475] hv_vmbus: child device àõsèè0_5 unregistered

By logging the message just before calling device_unregister, the correct device name is printed:
[ 3145.034652] hv_vmbus: child device vmbus_0_5 unregistered

Signed-off-by: Fernando M Soto <fsoto@xxxxxxxxxxxxxxxxxxx>
--- linux-3.10-rc5/drivers/hv/vmbus_drv.c.orig 2013-06-13 19:20:55.359511352 -0400
+++ linux-3.10-rc5/drivers/hv/vmbus_drv.c 2013-06-13 19:21:39.299511695 -0400
@@ -698,14 +698,14 @@ int vmbus_device_register(struct hv_devi
void vmbus_device_unregister(struct hv_device *device_obj)
+ pr_info("child device %s unregistered\n",
+ dev_name(&device_obj->device));
* Kick off the process of unregistering the device.
* This will call vmbus_remove() and eventually vmbus_device_release()
- pr_info("child device %s unregistered\n",
- dev_name(&device_obj->device));


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/