Re: [PATCH 1/3] drivers: pinctrl sleep and idle states in the core

From: Stephen Warren
Date: Thu Jun 13 2013 - 18:02:11 EST

On 06/11/2013 02:28 AM, Linus Walleij wrote:
> On Wed, Jun 5, 2013 at 7:22 PM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote:
>>> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
>>> +int pinctrl_pm_select_default_state(struct device *dev)
>>> +int pinctrl_pm_select_sleep_state(struct device *dev)
>>> +int pinctrl_pm_select_idle_state(struct device *dev)
>> The implementation of those 3 functions is basically identical. I'd be
>> inclined to move it to a helper function, and just pass (dev,
>> pins->xxx_state) to it.
> Just to follow up on this now that I'm adding one more state.
> I tried to create a refactoring patch for this but couldn't come
> up with anything apropriate along the lines above. For example
> this function:

Don't you just want something very roughly like:

int pinctrl_pm_select_xxx_state(struct device *dev,
unsigned long offset, char *name)
struct dev_pin_info *pins = dev->pins;
struct pinctrl_state **s = (void *)(((char *)pins) + offset)
int ret;

if (!pins)
return 0;
if (IS_ERR(*s))
return 0; /* No default state */
ret = pinctrl_select_state(pins->p, *s);
if (ret)
dev_err(dev, "failed to activate %s pinctrl state\n",
return ret;

int pinctrl_pm_select_default_state(struct device *dev)
return pinctrl_pm_select_xxx_state(dev,
offsetof(struct dev_pin_info, default_state),

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at