Re: [PATCH v3] ethernet/arc/arc_emac - Add new driver

From: David Miller
Date: Thu Jun 13 2013 - 15:54:28 EST


From: Joe Perches <joe@xxxxxxxxxxx>
Date: Thu, 13 Jun 2013 11:33:21 -0700

> On Thu, 2013-06-13 at 21:25 +0300, Andy Shevchenko wrote:
>> On Thu, Jun 13, 2013 at 5:37 PM, Alexey Brodkin
>> > + if (unlikely((info & OWN_MASK) == FOR_EMAC)) {
>> > + /* BD is still owned by EMAC */
>> > + continue;
>> > + }
>>
>> Redundant braces.
>
> Maybe not. Braces can be a visual aid when there is
> a comment in the test.

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/