Re: [PATCH v2 3/3] pinctrl: exynos: ack level-triggered interruptsbefore unmasking

From: Linus Walleij
Date: Thu Jun 13 2013 - 14:20:16 EST

On Thu, Jun 13, 2013 at 6:38 PM, Doug Anderson <dianders@xxxxxxxxxxxx> wrote:

> A level-triggered interrupt should be acked after the interrupt line
> becomes inactive and before it is unmasked, or else another interrupt
> will be immediately triggered. Acking before or after calling the
> handler is not enough.
> Signed-off-by: Luigi Semenzato <semenzato@xxxxxxxxxxxx>
> Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> ---
> Changes in v2:
> - Greatly simplified using Tomasz's suggestion of irqd_get_trigger_type
> - Moved acking out of the bank spinlock since since it's not needed.
> - Linus W. has already applied parts 1 and 2, so not resending.

Thanks, this v2 version applied with Tomasz ACK.

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at