Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interruptsbefore unmasking

From: Doug Anderson
Date: Thu Jun 13 2013 - 12:34:50 EST


On Thu, Jun 13, 2013 at 3:54 AM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote:
> Hi Doug,
> On Wednesday 12 of June 2013 10:33:19 Doug Anderson wrote:
>> A level-triggered interrupt should be acked after the interrupt line
>> becomes inactive and before it is unmasked, or else another interrupt
>> will be immediately triggered. Acking before or after calling the
>> handler is not enough.
> Nice catch.
> I guess that pinctrl-s3c64xx will need similar fix as well, won't it?

It needs this whole series of 3, probably. The mask and unmask need
the lock and as well as the acking for level interrupts.

I don't have any way to test that code but it's a pretty simple change
to make. Do you want to do it or do you have an idea of someone who

> I think you can eliminate most of the code by doing this following way:
> if (irqd_get_trigger_type(irqd) & IRQ_TYPE_LEVEL_MASK)
> exynos_gpio_irq_ack(irqd);

Duh, right. OK, v2 coming shortly. Thank you for pointing out the
right way to do this! :)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at