Re: [PATCH] fuse: hold i_mutex in fuse_file_fallocate()

From: Maxim Patlasov
Date: Thu Jun 13 2013 - 03:16:34 EST

Anand, Brian,

06/12/2013 11:04 PM, Anand Avati ÐÐÑÐÑ:
On 6/11/13 3:59 AM, Maxim Patlasov wrote:

- if (mode & FALLOC_FL_PUNCH_HOLE) {
+ if (lock_inode)

+ if (mode & FALLOC_FL_PUNCH_HOLE)
- }

Just for clarity, can you make the condition to check FALLOC_FL_PUNCH_HOLE and call to fuse_set_nowrite() nested within the larger if (lock_inode) { .. } block? fuse_set_nowrite() should not be called without i_mutex acquired. The current style of calling mutex_lock() and fuse_set_nowrite() in separate conditions can potentially cause bugs in the future if they were to get re-ordered due to some unrelated patch. Nesting them makes the relation more explicit and clear.

Thanks a lot for review. I'll post updated patch soon.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at