Re: [PATCH] ncpfs: fix rmdir returns Device or resource busy

[Al Viro]

On Fri, Jun 07, 2013 at 05:14:52PM +0100, Al Viro wrote:
> On Fri, Jun 07, 2013 at 11:09:05AM -0500, Dave Chiluk wrote:
> > Can't you just use the patch from my original e-mail?  Anyhow I attached
> > it an already signed-off patch.
> > 
> > Al Viro Can you integrate it now?
> 
> Applied...  FWIW, patch directly in mail body is more convenient to deal with.

Actually, looking at that stuff...  Why are we bothering with -EBUSY for
removal of busy directories on ncpfs, anyway?  It's not just rmdir(), it's
overwriting rename() as well.  IS_DEADDIR checks in fs/namei.c and fs/readdir.c
mean that the only method of ncpfs directories that might get called after
successful removal is ->setattr() and it would be trivial to add the check
in ncp_notify_change() that would make it fail for dead directories without
bothering the server at all...

Related question: what happens if you open / unlink / fchmod on ncpfs?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/