[RFC: PATCH] err.h: silence warning when using IS_ERR on void __iomem *

From: Marc Kleine-Budde
Date: Wed Jun 12 2013 - 17:31:21 EST

Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()")
introduced devm_ioremap_resource() and encourage to check its return value with
IS_ERR(). This however leads to the following sparse warnings, as
devm_ioremap_resource() returns a void __iomem pointer:

drivers/net/can/c_can/c_can_platform.c:205:32: warning: incorrect type in argument 1 (different address spaces)
drivers/net/can/c_can/c_can_platform.c:205:32: expected void const *ptr
drivers/net/can/c_can/c_can_platform.c:205:32: got unsigned int [noderef] [usertype] <asn:2>*raminit_ctrlreg

This patch silences the warning by introducing a macro to force cast the
pointer to a plain const void *.

Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>

I think this macro is a bit ugly, is there a better way to make sparse happy?
If we agree on a solution other functions in this file have to be wrapped.


include/linux/err.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/linux/err.h b/include/linux/err.h
index f2edce2..1a5a57b 100644
--- a/include/linux/err.h
+++ b/include/linux/err.h
@@ -29,11 +29,13 @@ static inline long __must_check PTR_ERR(const void *ptr)
return (long) ptr;

-static inline long __must_check IS_ERR(const void *ptr)
+static inline long __must_check __IS_ERR(const void *ptr)
return IS_ERR_VALUE((unsigned long)ptr);

+#define IS_ERR(__ptr) __IS_ERR((const void __force *)__ptr)
static inline long __must_check IS_ERR_OR_NULL(const void *ptr)
return !ptr || IS_ERR_VALUE((unsigned long)ptr);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/