Re: [PATCH] checkpatch: forgive use of mixed case variablesmeasuring units

From: Jason Cooper
Date: Wed Jun 12 2013 - 12:18:09 EST


On Wed, Jun 12, 2013 at 09:02:15AM -0700, Joe Perches wrote:
> On Wed, 2013-06-12 at 15:59 +0300, Phil Carmody wrote:
> > I agree that a creeping list of exceptions where CamelCase
> > is to be overlooked would be bad, but I would argue that
> > perhaps my exceptions aren't actual CamelCase - they're
> > (pretending to be) SI units, and just happen to match the
> > CamelCase regexp. I did a grep for my regexp, and everything
> > I noticed in a quick scan did look like a justifiable
> > variable name.
>
> Maybe, but this regex misses variants like:
>
> regulator_min_uA_show
>
> Maybe "^[a-z_]*_[numk][VAS](?:_\w+)?$"
>
> But this regex also does not match on other common
> sound variants "_dB", "_mB" and temperature like "_mC".

And _dBm ...

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/