Re: [PATCH] HID: multitouch: prevent memleak with the allocatedname

From: Jiri Kosina
Date: Wed Jun 12 2013 - 05:15:30 EST

On Wed, 29 May 2013, Benjamin Tissoires wrote:

> mt_free_input_name() was never called during .remove():
> hid_hw_stop() removes the hid_input items in hdev->inputs, and so the
> list is therefore empty after the call. In the end, we never free the
> special names that has been allocated during .probe().
> Restore the original name before freeing it to avoid acessing already
> freed pointer.
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>

I have now applied this one and will send it to Linus for next -rc.

If we are going down the path of using devm API, as proposed by Andy, that
will require much more throgough review of interaction with input
subsystem, so definitely not a late -rc regression fix material.


Jiri Kosina
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at