Re: Get rid of cpuinit?

From: Greg KH
Date: Tue Jun 11 2013 - 20:55:38 EST


On Tue, Jun 11, 2013 at 08:31:55PM -0400, Paul Gortmaker wrote:
> On Tue, May 28, 2013 at 5:20 AM, Ingo Molnar <mingo@xxxxxxxxxx> wote:
> >
> > * Greg KH <greg@xxxxxxxxx> wrote:
> >
> >> On Mon, May 20, 2013 at 03:35:43PM -0700, H. Peter Anvin wrote:
> >> > We have gotten rid of devinit markup. A recent patch of Linus' makes me
> >> > wonder if we similarly should get rid of cpuinit markup?
> >> >
> >> > Just as with devices, the CPU hotplug machinery has been leveraged to
> >> > support a number of pieces of functionality such as suspend, which means
> >> > that on anything but the most embedded systems this functionality is
> >> > likely needed anyway.
> >> >
> >> > On x86-64, for an "allyesconfig" build, the total amount of space in all
> >> > the .cpu* sections combined is 100K.
> >>
> >> No objection from me on removing it, it just causes problems from what I
> >> can tell.
> >
> > Indeed, there's a steady trickle of mis-annotated cpuinit sections, and no
> > real tooling to make the annotations automatic or so in most of the cases.
> > Manual simply does not seem to work in this case.
>
> Is anyone actively working on weeding this out? If not, it is probably
> one of those tree-wide kind of changes that I can volunteer to tackle...

I say go for it.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/