Re: [PATCH] sound/sgtl5000: fix codec register initial values andmask

From: Fabio Estevam
Date: Tue Jun 11 2013 - 08:21:13 EST

Hi Oskar,

On 06/11/2013 05:12 AM, Oskar Schirmer wrote:
According to documentation bit 3:2 in register SSS_CTRL are
reserved and zero, so initially setting the register to 0x0008
does not make much sense. Instead, bit 4 should be marked set,
as this is the power up default.

Further, mask computation in declarative part is obviously wrong:
Fix FRAC DIVISOR to provide an 11 bit mask correctly.

Signed-off-by: Oskar Schirmer <oskar@xxxxxxxxx>

Please rebase your patch against Mark Brown's topic/sgtl5000 branch:

After that, you can add my:

Tested-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at