Re: [PATCH v10 net-next 2/6] net: add low latency socket poll

From: Willem de Bruijn
Date: Mon Jun 10 2013 - 12:37:16 EST


On Mon, Jun 10, 2013 at 10:29 AM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> On Mon, 2013-06-10 at 11:39 +0300, Eliezer Tamir wrote:
>> Adds an ndo_ll_poll method and the code that supports it.
>> This method can be used by low latency applications to busy-poll
>> Ethernet device queues directly from the socket code.
>> sysctl_net_ll_poll controls how many microseconds to poll.
>> Default is zero (disabled).
>> Individual protocol support will be added by subsequent patches.
>>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@xxxxxxxxx>
>> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>
>> Signed-off-by: Eliezer Tamir <eliezer.tamir@xxxxxxxxxxxxxxx>
>> ---
>>
>> Documentation/sysctl/net.txt | 7 ++
>> include/linux/netdevice.h | 3 +
>> include/linux/skbuff.h | 8 ++
>> include/net/ll_poll.h | 148 ++++++++++++++++++++++++++++++++++++++++++
>> include/net/sock.h | 4 +
>> include/uapi/linux/snmp.h | 1
>> net/Kconfig | 12 +++
>> net/core/skbuff.c | 4 +
>> net/core/sock.c | 6 ++
>> net/core/sysctl_net_core.c | 10 +++
>> net/ipv4/proc.c | 1
>> net/socket.c | 6 ++
>> 12 files changed, 208 insertions(+), 2 deletions(-)
>> create mode 100644 include/net/ll_poll.h
>
> Acked-by: Eric Dumazet <edumazet@xxxxxxxxxx>
>

Tested-by: Willem de Bruijn <willemb@xxxxxxxxxx>

Per Eliezer's request, I applied v10 to a small set of workloads
(netperf tcp_rr, udp_rr, 100x tcp_rr, 100x udp_rr and a poll()-based
tcp rr) for some functional testing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/