Re: [PATCH v5 2/5] s390/vmcore: Use ELF header in new memoryfeature

From: Michael Holzheu
Date: Mon Jun 10 2013 - 09:48:33 EST


On Mon, 10 Jun 2013 22:36:57 +0900
HATAYAMA Daisuke <d.hatayama@xxxxxxxxx> wrote:

> > -static int setup_kdump_elfcorehdr(void)
> > +void elfcorehdr_free(void)
> > {
> > - size_t elfcorebuf_sz;
> > - char *elfcorebuf;
> > -
> > - if (!OLDMEM_BASE || is_kdump_kernel())
> > - return -EINVAL;
> > - s390_elf_corehdr_create(&elfcorebuf, &elfcorebuf_sz);
> > - elfcorehdr_addr = (unsigned long long) elfcorebuf;
> > - elfcorehdr_size = elfcorebuf_sz;
> > - return 0;
> > + if (!elfcorehdr_newmem)
> > + return;
> > + vfree(elfcorehdr_newmem);
>
> kfree is correct here?

You are right, I fixed that!

Thanks!
Michael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/