Re: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

From: Heiko Stübner
Date: Mon Jun 10 2013 - 09:11:01 EST

Am Montag, 10. Juni 2013, 15:00:41 schrieb Linus Walleij:
> On Sun, Jun 9, 2013 at 2:01 AM, Heiko Stübner <heiko@xxxxxxxxx> wrote:
> (...)
> > +#include <linux/irqchip/chained_irq.h>
> > +#include <linux/clk-provider.h>
> > +#include <dt-bindings/pinctrl/rockchip.h>
> Hm I don't know if we're supposed to do things like this actually.
> It depends on whether the <dt-bindings/*> hierarchy is supposed
> to stay in the kernel after the device trees are moved out to a
> separate repo.
> Grant/Rob, shall we do this in drivers?

we can get rid of it, if it's controversial.

The only constant that gets used is RK_FUNC_GPIO in
rockchip_pmx_gpio_set_direction and rockchip_irq_set_type to not have arbitary
"0"-values when switching to the gpio function.

So it wouldn't be problem to simply keep this constant in the driver itself
instead of including the dt-binding constants.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at