Re: [PATCH] mtd: orion_nand: Improve error handling inorion_nand_probe

From: Dan Carpenter
Date: Sun Jun 09 2013 - 16:59:11 EST

On Sun, Jun 09, 2013 at 10:27:03PM +0300, Andy Shevchenko wrote:
> On Sun, Jun 9, 2013 at 10:17 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> > On Sun, Jun 09, 2013 at 08:15:20PM +0300, Andy Shevchenko wrote:
> []
> >> What about another patch (that I guess should go first) that converts
> >> printk to dev_* or pr_*?
> > Huh, what? Those are two totally unrelated things. Emil's patch is
> > a bug fix.
> To be precise his patch is bugfix and cleanup at once.
> My proposal is to add a clean up patch.

The printk idea isn't a bad one, it's just totally unrelated to what
the patch is doing. You can't just randomly tell people to do a
bunch of work for no reason. "Good bugfix, but before we apply it
you have to mow my lawn."

dan carpenter
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at