Re: [PATCH] regulator: 88pm800: add regulator driver

[Mark Brown]

On Tue, May 28, 2013 at 05:10:00AM -0700, Chao Xie wrote:

Please fix your mail client to word wrap within paragraphs.

> Thanks for your review.
> Because structure regulator_desc only accepts the voltage table as constant.
> struct regulator_desc {
> 	...
> 	const unsigned int *volt_table;
> 	...
> };
> If we want to make use of the volt_table, and the help functions regulator_map_voltage_iterate and regulator_list_voltage_table, we have to initialize the tables as what we do now.

If you are calculating this stuff you shouldn't be providing a voltage
table at all.  The whole point is that these things shouldn't be using
voltage tables.

Attachment: signature.asc
Description: Digital signature