Re: [PATCH 1/2] dma: at_hdmac: remove unnecessaryplatform_set_drvdata()

[Vinod Koul]

On Mon, May 06, 2013 at 12:53:33PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
Applied both, Thanks

--
~Vinod
> ---
>  drivers/dma/at_hdmac.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index e923cda..c093ab7 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -1472,7 +1472,6 @@ err_of_dma_controller_register:
>  	dma_async_device_unregister(&atdma->dma_common);
>  	dma_pool_destroy(atdma->dma_desc_pool);
>  err_pool_create:
> -	platform_set_drvdata(pdev, NULL);
>  	free_irq(platform_get_irq(pdev, 0), atdma);
>  err_irq:
>  	clk_disable(atdma->clk);
> @@ -1497,7 +1496,6 @@ static int at_dma_remove(struct platform_device *pdev)
>  	dma_async_device_unregister(&atdma->dma_common);
>  
>  	dma_pool_destroy(atdma->dma_desc_pool);
> -	platform_set_drvdata(pdev, NULL);
>  	free_irq(platform_get_irq(pdev, 0), atdma);
>  
>  	list_for_each_entry_safe(chan, _chan, &atdma->dma_common.channels,
> -- 
> 1.7.2.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/