Re: [patch v2 3/6] mm/memory_hotplug: Disable memory hotremove for 32bit

From: KOSAKI Motohiro
Date: Sun May 26 2013 - 07:59:30 EST


>> As KOSAKI Motohiro mentioned, memory hotplug don't support 32bit since
>> it was born,
>
> Why? any reference? This reasoning is really weak.

I have no seen any highmem support in memory hotplug code and I don't think this
patch fixes all 32bit highmem issue. If anybody are interesting to
support it, it is good thing. But in fact, _now_ it is broken when
enable HIGHMEM.
So, I just want to mark broken until someone want to support highmem
and verify overall.

And, yes, this patch is no good. Kconfig doesn't describe why disable
when highmem.
So,

depends on 64BIT || !HIGHMEM || BROKEN

maybe clear documentation more.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/