Re: [PATCH v2 net-next 1/4] net: implement support for low latencysocket polling

From: David Miller
Date: Mon May 20 2013 - 05:16:21 EST


From: Joe Perches <joe@xxxxxxxxxxx>
Date: Mon, 20 May 2013 01:29:47 -0700

> On Mon, 2013-05-20 at 00:54 -0700, David Miller wrote:
>> From: Eliezer Tamir <eliezer.tamir@xxxxxxxxxxxxxxx>
> []
>> > {
>> > struct socket *sock;
>> > + unsigned int poll_result;
>>
>> Please order local variable declarations from longest line to
>> shortest line.
>
> reverse christmas tree doesn't seem especially valuable or
> sensible for automatics.

It looks nicer to the eyes and provides a predictable pattern
to look at.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/