Re: [PATCH 1/5] drivers: net: usb: rtl8150: bug fixing and cleanup

[Petko Manolov]

On Sat, 18 May 2013, Francois Romieu wrote:

> Petko Manolov <petkan@xxxxxxxxxxxxx> :
> > From: Petko Manolov <petkan@xxxxxxxxxxxxx>
> > 
> > Moving constant and structure definitions out of rtl8150.c;
> 
> What's the point ?

The general logic of having .h files applies.
 
> [...]
> > ---
> >  drivers/net/usb/rtl8150.c |  121 +----------------------------------
> >  1 file changed, 2 insertions(+), 119 deletions(-)
> > 
> > diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> > index a491d3a..7d1897b 100644
> > --- a/drivers/net/usb/rtl8150.c
> > +++ b/drivers/net/usb/rtl8150.c
> > @@ -17,132 +17,15 @@
> >  #include <linux/usb.h>
> >  #include <asm/uaccess.h>
> >  
> > +#include "rtl8150.h"
> 
> It won't compile. You shouldn't do that.

It does compile.  Both inside and outside of the tree.

If the proper place for rtl8150.h is somewhere in include/linux/... then 
it is different matter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/