Re: [PATCH 5/5] drivers: net: usb: rtl8150: bug fixing and cleanup

[Petko Manolov]

On Sat, 18 May 2013, Francois Romieu wrote:

> Petko Manolov <petkan@xxxxxxxxxxxxx> :
> [...]
> > @@ -681,16 +681,15 @@ static int rtl8150_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd)
> >  }
> >  
> >  static const struct net_device_ops rtl8150_netdev_ops = {
> > -	.ndo_open		= rtl8150_open,
> > -	.ndo_stop		= rtl8150_close,
> > -	.ndo_do_ioctl		= rtl8150_ioctl,
> > -	.ndo_start_xmit		= rtl8150_start_xmit,
> > -	.ndo_tx_timeout		= rtl8150_tx_timeout,
> > -	.ndo_set_rx_mode	= rtl8150_set_multicast,
> > -	.ndo_set_mac_address	= rtl8150_set_mac_address,
> > -
> > -	.ndo_change_mtu		= eth_change_mtu,
> > -	.ndo_validate_addr	= eth_validate_addr,
> > +	.ndo_open = rtl8150_open,
> > +	.ndo_stop = rtl8150_close,
> > +	.ndo_do_ioctl = rtl8150_ioctl,
> > +	.ndo_start_xmit = rtl8150_start_xmit,
> > +	.ndo_tx_timeout = rtl8150_tx_timeout,
> > +	.ndo_set_rx_mode = rtl8150_set_multicast,
> > +	.ndo_set_mac_address = rtl8150_set_mac_address,
> > +	.ndo_change_mtu	= eth_change_mtu,
> > +	.ndo_validate_addr = eth_validate_addr,
> 
> This is wrong.

I am inclined to agree with you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/