Re: [PATCH 3/4] ipmi: Improve error messages on failed irq enable

From: Corey Minyard
Date: Thu May 16 2013 - 23:48:12 EST

On 05/16/2013 05:23 PM, Andy Lutomirski wrote:

/* We got the flags from the SMI, now handle them. */
smi_info->handlers->get_result(smi_info->si_sm, msg, 4);
- if (msg[2] != 0)
- dev_warn(smi_info->dev, "Could not enable interrupts"
- ", failed set, using polled mode.\n");
- else
+ if (msg[2] != 0) {
+ dev_warn(smi_info->dev,
+ "Couldn't set irq info: %x.\n", msg[2]);
+ dev_warn(smi_info->dev,
+ "Maybe ok, but ipmi might run very slowly.\n");
+ } else
Minor nit: it would be nice if these warnings were collapsed into a
single printk -- that would save me a whitelist entry of acceptable
KERN_WARNING messages :)

Yeah, the trouble is that checkpatch will give a warning if you split a string
between two lines or if a line is longer than 80 characters. I'm not creative
enough to fit it into a single line. Maybe I'm trying to be too literal here,
but I split it into two prints to avoid the warning.

My Dell 12g server says:

[97627.407724] ipmi_si ipmi_si.0: Using irq 10
[97627.421369] ipmi_si ipmi_si.0: Couldn't set irq info: cc.
[97627.427389] ipmi_si ipmi_si.0: Maybe ok, but ipmi might run very slowly.

Tested-by: Andy Lutomirski <luto@xxxxxxxxxxxxxx>

Thanks a bunch.



To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at