Re: [PATCH v4] usb host: Faraday USB2.0 FUSBH200-HCD driver

From: Greg KH
Date: Thu May 16 2013 - 23:42:35 EST

On Fri, Apr 26, 2013 at 09:37:20AM +0000, Yuan-Hsin Chen wrote:
> FUSBH200-HCD is an USB2.0 hcd for Faraday FUSBH200.
> FUSBH200 is an ehci-like controller with some differences.
> First, register layout of FUSBH200 is incompatible with EHCI.
> Furthermore, FUSBH200 is lack of siTDs which means iTDs
> are used for both HS and FS ISO transfer.
> Signed-off-by: Yuan-Hsin Chen <yhchen@xxxxxxxxxxxxxxxx>

This patch breaks the build on my machine, so I can't accept it:
CC [M] drivers/usb/host/fusbh200-hcd.o
drivers/usb/host/fusbh200-hcd.c: In function âdbg_hcc_paramsâ:
drivers/usb/host/fusbh200-hcd.c:149:2: error: implicit declaration of function âHCC_HW_PREFETCHâ [-Werror=implicit-function-declaration]
drivers/usb/host/fusbh200-hcd.c:149:2: error: implicit declaration of function âHCC_32FRAME_PERIODIC_LISTâ [-Werror=implicit-function-declaration]
drivers/usb/host/fusbh200-hcd.c:149:2: warning: format â%dâ expects argument of type âintâ, but argument 6 has type âchar *â [-Wformat]
drivers/usb/host/fusbh200-hcd.c: At top level:
drivers/usb/host/fusbh200-hcd.c:906:12: warning: âdebug_lpm_closeâ defined but not used [-Wunused-function]
cc1: some warnings being treated as errors

Please be more careful. Can you fix this up and resend it?


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at