Re: [PATCH v2] cs5535-mfgpt: Add another reset method

From: Stephen Rothwell
Date: Tue Apr 02 2013 - 03:17:35 EST


Hi Richard,

On Tue, 2 Apr 2013 08:46:37 +0200 Richard Weinberger <richard@xxxxxx> wrote:
>
> The CS5535/CS5536 MFGPT has no support to reset the device.
> The current method uses an undocumented bit but does not work on all
> devices. At least on my ALIX board it completely freezes the board.
>
> This new method tries to soft reset all timers by unconfiguring them.
> But this does not clear the RO setup register and therefore it has to
> be ignored while probing.
>
> Resetting the timers is not only needed on broken BIOSes also when
> kexec is used. Otherwise the new kernel will find preconfigured timers
> and odd things will happen.
>
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---
> drivers/misc/cs5535-mfgpt.c | 41 +++++++++++++++++++++++++++++++++++++----
> 1 file changed, 37 insertions(+), 4 deletions(-)

Greg will probably want an incremental fix patch as he does not rewrite
his trees.

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature