RE: [PATCH v7 03/14] spi/spi-atmel: add physical base address

[Yang, Wenyou]

Hi, Mark,

> -----Original Message-----
> From: Yang, Wenyou
> Sent: 2013年4月2日 13:50
> To: 'Mark Brown'
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; grant.likely@xxxxxxxxxxxx;
> richard.genoud@xxxxxxxxx; plagnioj@xxxxxxxxxxxx; Ferre, Nicolas; Lin, JM;
> spi-devel-general@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: RE: [PATCH v7 03/14] spi/spi-atmel: add physical base address
> 
> Hi, Mark,
> 
> > -----Original Message-----
> > From: Mark Brown [mailto:broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx]
> > Sent: 2013年4月1日 21:42
> > To: Yang, Wenyou
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; grant.likely@xxxxxxxxxxxx;
> > richard.genoud@xxxxxxxxx; plagnioj@xxxxxxxxxxxx; Ferre, Nicolas; Lin, JM;
> > spi-devel-general@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH v7 03/14] spi/spi-atmel: add physical base address
> >
> > On Tue, Mar 19, 2013 at 03:43:36PM +0800, Wenyou Yang wrote:
> >
> > > +++ b/drivers/spi/spi-atmel.c
> > > @@ -196,6 +196,7 @@ struct atmel_spi_caps {  struct atmel_spi {
> > >  	spinlock_t		lock;
> > >
> > > +	resource_size_t		phybase;
> > >  	void __iomem		*regs;
> > >  	int			irq;
> > >  	struct clk		*clk;
> >
> > This looks like the wrong type?
> 
I got it, you are right, you mean It should be used " phys_addr_t " type.

	phys_addr_t	phybase;

Thanks.

Best Regards,
Wenyou Yang.

> I double checked.
> 
> The type ' resource_size_t ' is defined in include/linux/ types.h as below,
> 
> typedef phys_addr_t resource_size_t;
> 
> I think it is OK.
> 
> Best Regards,
> Wenyou Yang
N?叉??y??b??千v??藓{.n???{?赙zXФ?塄}?财??j:+v???赙zZ+€?zf＂?????i????ア??璀??撷f?^j谦y??@A?囤?0鹅h??i