RE: [PATCH v7 03/14] spi/spi-atmel: add physical base address

From: Yang, Wenyou
Date: Tue Apr 02 2013 - 01:50:11 EST


Hi, Mark,

> -----Original Message-----
> From: Mark Brown [mailto:broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx]
> Sent: 2013年4月1日 21:42
> To: Yang, Wenyou
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; grant.likely@xxxxxxxxxxxx;
> richard.genoud@xxxxxxxxx; plagnioj@xxxxxxxxxxxx; Ferre, Nicolas; Lin, JM;
> spi-devel-general@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v7 03/14] spi/spi-atmel: add physical base address
>
> On Tue, Mar 19, 2013 at 03:43:36PM +0800, Wenyou Yang wrote:
>
> > +++ b/drivers/spi/spi-atmel.c
> > @@ -196,6 +196,7 @@ struct atmel_spi_caps { struct atmel_spi {
> > spinlock_t lock;
> >
> > + resource_size_t phybase;
> > void __iomem *regs;
> > int irq;
> > struct clk *clk;
>
> This looks like the wrong type?

I double checked.

The type ' resource_size_t ' is defined in include/linux/ types.h as below,

typedef phys_addr_t resource_size_t;

I think it is OK.

Best Regards,
Wenyou Yang
㈤旃??????+-遍荻?w??笔???dz罐??骅w*jg??????/??罐????璀??摺?囤??????:+v???佶>W?贽i?xPj??? -?+?d?