Re: [PATCH] sound: max98090: Remove executable bit

From: Joe Perches
Date: Thu Mar 21 2013 - 15:17:58 EST


On Thu, 2013-03-21 at 19:44 +0100, Mark Brown wrote:
> On Thu, Mar 21, 2013 at 10:53:13AM -0700, Joe Perches wrote:
> > On Thu, 2013-03-21 at 18:44 +0100, Mark Brown wrote:
>
> > > That one needs a bit more taste and thought to work out what's
> > > appropraite than can be guaranteed easily with a script, things like
> > > working out drive level prefixes for example.
>
> > [perfectly useful git applypatch-msg hook script removed]
>
> No, it really isn't. Have you tried looking at the output? It's not
> going to do the right thing for the subject line here for example, never
> mind any other cases.

Define "the right thing" for this instance.

The commit isn't in -next so I have no idea what
you actually applied. (nor do I really care btw)

Did you try it?

It commits:

ASoC: sound: max98080: Remove executable bit

If you're really anal about it and you want
sound: for sound/soc removed,

perl -p -i -e 's/^(?:ASoC:\s*)?(?:sound:\s*)?(.*)$/ASoC: $1/g if 1 .. 1' ${1+"$@"}

This is a "your taste" issue only, and do keep in mind
mountains vs molehills.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/