Re: [PATCH 1/2] driver: serial-omap: move max uart count into generic header file.

From: Kevin Hilman
Date: Mon Mar 18 2013 - 14:45:35 EST


Sourav Poddar <sourav.poddar@xxxxxx> writes:

> OMAP_MAX_HSUART_PORTS is moved to omap_serial header file.

Why?

You started to explain it in the cover letter, but a full description
belongs here for the permanent git history.

Kevin

> Cc: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxx>
> Cc: Rajendra nayak <rnayak@xxxxxx>
> Signed-off-by: Sourav Poddar <sourav.poddar@xxxxxx>
> ---
> drivers/tty/serial/omap-serial.c | 2 --
> include/linux/platform_data/serial-omap.h | 1 +
> 2 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> index 5722eaf..4c2ba9f 100644
> --- a/drivers/tty/serial/omap-serial.c
> +++ b/drivers/tty/serial/omap-serial.c
> @@ -43,8 +43,6 @@
> #include <linux/pinctrl/consumer.h>
> #include <linux/platform_data/serial-omap.h>
>
> -#define OMAP_MAX_HSUART_PORTS 6
> -
> #define UART_BUILD_REVISION(x, y) (((x) << 8) | (y))
>
> #define OMAP_UART_REV_42 0x0402
> diff --git a/include/linux/platform_data/serial-omap.h b/include/linux/platform_data/serial-omap.h
> index ff9b0aa..92c48c2 100644
> --- a/include/linux/platform_data/serial-omap.h
> +++ b/include/linux/platform_data/serial-omap.h
> @@ -29,6 +29,7 @@
> * is used as console uart.
> */
> #define OMAP_SERIAL_NAME "ttyO"
> +#define OMAP_MAX_HSUART_PORTS 6
>
> struct omap_uart_port_info {
> bool dma_enabled; /* To specify DMA Mode */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/