Re: [PATCH] clocksource : nomadik-mtu : fix missing irq initialization

From: Daniel Lezcano
Date: Sat Feb 23 2013 - 01:19:07 EST

On 02/22/2013 06:21 PM, Linus Walleij wrote:
> On Fri, Feb 22, 2013 at 4:44 PM, Daniel Lezcano
> <daniel.lezcano@xxxxxxxxxx> wrote:
>> This patch fix the clock device irq field which is not initialized.
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Makes perfect sense:
> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Sorry that I might have missed some background here or just be
> out-of-track with things, how did this driver work for years without
> the irq assigned? Or was this field recently introduced?

The irq is assigned through:

setup_irq(irq, &nmdk_timer_irq);

two lines above but the clockevent's irq field was not set.

I did not investigate a lot, but at the first glance it worked because
the code path used by the default kernel configuration (CONFIG_NO_HZ)
does not use this field.

But when using the dynamic irq affinity [1], I noticed it was set to 0.


-- Daniel

<> â Open source software for ARM SoCs

Follow Linaro: <> Facebook |
<!/linaroorg> Twitter |
<> Blog

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at