Re: [PATCH 04/16] virtio-blk: use virtqueue_start_buf on bio path

From: Rusty Russell
Date: Thu Feb 21 2013 - 01:56:10 EST

Asias He <asias@xxxxxxxxxx> writes:

> On 02/19/2013 03:56 PM, Rusty Russell wrote:
>> (This is a respin of Paolo Bonzini's patch, but it calls
>> virtqueue_add_sgs() instead of his multi-part API).
> (This subject needs to be changed to reflect using of virtqueue_add_sgs)

Thanks, done.

>> -static inline int __virtblk_add_req(struct virtqueue *vq,
>> - struct virtblk_req *vbr,
>> - unsigned long out,
>> - unsigned long in)
>> +static int __virtblk_add_req(struct virtqueue *vq,
>> + struct virtblk_req *vbr)
>> {
>> - return virtqueue_add_buf(vq, vbr->sg, out, in, vbr, GFP_ATOMIC);
>> + struct scatterlist hdr, tailer, *sgs[3];
> 'status' might be better than 'tailer'. We are using status in other
> places.

Indeed, done.

> Reviewed-by: Asias He <asias@xxxxxxxxxx>

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at