Re: [PATCH] rtc: max77686: add missing variable initialization

[Andrew Morton]

On Fri, 15 Feb 2013 16:45:38 +0900
Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:

> Fixed build warning as below:
> 
> drivers/rtc/rtc-max77686.c: In function 'max77686_rtc_update':
> drivers/rtc/rtc-max77686.c:147:6: warning: 'data' may be used uninitialized in this function [-Wuninitialized]
> 
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> ---
>  drivers/rtc/rtc-max77686.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
> index abe27c0..2634fed 100644
> --- a/drivers/rtc/rtc-max77686.c
> +++ b/drivers/rtc/rtc-max77686.c
> @@ -133,7 +133,7 @@ static int max77686_rtc_update(struct max77686_rtc_info *info,
>  	enum MAX77686_RTC_OP op)
>  {
>  	int ret;
> -	unsigned int data;
> +	unsigned int data = 0;
>  
>  	switch (op) {
>  	case MAX77686_RTC_WRITE:

spose so.  But the end result is rather awkward-looking.

As `op' must be (and is) one of MAX77686_RTC_WRITE and
MAX77686_RTC_READ, the straightfoward implementation is


static int max77686_rtc_update(struct max77686_rtc_info *info,
	enum MAX77686_RTC_OP op)
{
	int ret;
	unsigned int data;

	if (op == MAX77686_RTC_WRITE)
		data = 1 << RTC_UDR_SHIFT;
	else
		data = 1 << RTC_RBUDR_SHIFT;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/