Re: [PATCH 3/6] dma: coh901318_lli: avoid unbalanced locking
From: Linus Walleij
Date: Fri Feb 15 2013 - 15:52:28 EST
On Fri, Feb 15, 2013 at 3:56 PM, Andy Shevchenko
> On Fri, Feb 15, 2013 at 4:52 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>> On Tue, Feb 12, 2013 at 11:58 AM, Andy Shevchenko
>> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>>> I have not checked the code but there is a possibility that custom pool->lock
>>> is not needed at all due to dma_pool contains it's own lock.
>> Can you please change the description to something like:
>> "The coh901318_lli allocator releases a lock on the exit path without
>> taking it first".
> In v2 (that by fact already applied) I put following description:
> In case the len is 0 we must return without trying to unlock the
> lock that was
> not locked.
> Does it fit your suggestion?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/