Re: [PATCH] staging/panel: Mark local functions as static (fix smatch warnings)

From: David Howells
Date: Fri Feb 15 2013 - 05:56:07 EST

Peter Huewe <peterhuewe@xxxxxx> wrote:

> +static char old_keypad_profile[][4][9] = {
> {"S0", "Left\n", "Left\n", ""},
> {"S1", "Down\n", "Down\n", ""},
> {"S2", "Up\n", "Up\n", ""},

Things like this should likely be const also. There are several here.

> -void panel_lcd_print(char *s)
> +static void panel_lcd_print(char *s)

const char *s maybe?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at