Re: [PATCH 2/2 v2] kexec: Export PG_hwpoison flag into vmcoreinfo

[Atsushi Kumagai]

Hello Tanino-san,

On Fri, 15 Feb 2013 17:48:24 +0900
Mitsuhiro Tanino <mitsuhiro.tanino.gm@xxxxxxxxxxx> wrote:

> Hello Kumagai-san,
> 
> > I'm curious to know the status of this patch because I'll release
> > makedumpfile-1.5.2 with the feature to exclude hwpoison page soon.
> 
> I requested Andrew to merge the kernel side patch, and the patch
> has been added the -mm tree.
> 
> Please push the makedumpfile side patch into makedumpfile-1.5.2.

Thanks, I've released makedumpfile-1.5.2 with your patch:

http://lists.infradead.org/pipermail/kexec/2013-February/007954.html


Thanks
Atsushi Kumagai

> Regards,
> Mitsuhiro Tanino
> 
> > TO: mm-commits@xxxxxxxxxxxxxxx; 
> > CC: mitsuhiro.tanino.gm@xxxxxxxxxxx; ebiederm@xxxxxxxxxxxx; vgoyal@xxxxxxxxxx; 
> > Sender: akpm@xxxxxxxxxxxxxxxxxxxx
> > Sugject: + kexec-export-pg_hwpoison-flag-into-vmcoreinfo.patch added to -mm tree
> > Date: 2013/02/13 07:50
> > 
> > 
> > The patch titled
> >      Subject: kexec: export PG_hwpoison flag into vmcoreinfo
> > has been added to the -mm tree.  Its filename is
> >      kexec-export-pg_hwpoison-flag-into-vmcoreinfo.patch
> > 
> > Before you just go and hit "reply", please:
> >    a) Consider who else should be cc'ed
> >    b) Prefer to cc a suitable mailing list as well
> >    c) Ideally: find the original patch on the mailing list and do a
> >       reply-to-all to that, adding suitable additional cc's
> > 
> > *** Remember to use Documentation/SubmitChecklist when testing your code ***
> > 
> > The -mm tree is included into linux-next and is updated
> > there every 3-4 working days
> > 
> > ------------------------------------------------------
> > From: Mitsuhiro Tanino <mitsuhiro.tanino.gm@xxxxxxxxxxx>
> > Subject: kexec: export PG_hwpoison flag into vmcoreinfo
> > 
> > This patch exports a PG_hwpoison into vmcoreinfo when
> > CONFIG_MEMORY_FAILURE is defined.  "makedumpfile" needs to read
> > information of memory, such as 'mem_section', 'zone', 'pageflags' from
> > vmcore.
> > 
> > We introduce a function into "makedumpfile" to exclude hwpoison page from
> > vmcore dump.  In order to introduce this function, PG_hwpoison flag have
> > to export into vmcoreinfo.
> > 
> > Signed-off-by: Mitsuhiro Tanino <mitsuhiro.tanino.gm@xxxxxxxxxxx>
> > Acked-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
> > Cc: Mitsuhiro Tanino <mitsuhiro.tanino.gm@xxxxxxxxxxx>
> > Cc: Vivek Goyal <vgoyal@xxxxxxxxxx>
> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > ---
> > 
> >  kernel/kexec.c |    3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff -puN kernel/kexec.c~kexec-export-pg_hwpoison-flag-into-vmcoreinfo kernel/kexec.c
> > --- a/kernel/kexec.c~kexec-export-pg_hwpoison-flag-into-vmcoreinfo
> > +++ a/kernel/kexec.c
> > @@ -1537,6 +1537,9 @@ static int __init crash_save_vmcoreinfo_
> >  	VMCOREINFO_NUMBER(PG_private);
> >  	VMCOREINFO_NUMBER(PG_swapcache);
> >  	VMCOREINFO_NUMBER(PG_slab);
> > +#ifdef CONFIG_MEMORY_FAILURE
> > +	VMCOREINFO_NUMBER(PG_hwpoison);
> > +#endif
> >  	VMCOREINFO_NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE);
> >  
> >  	arch_crash_save_vmcoreinfo();
> > _
> > 
> > Patches currently in -mm which might be from mitsuhiro.tanino.gm@xxxxxxxxxxx are
> > 
> > kexec-export-pg_hwpoison-flag-into-vmcoreinfo.patch
> 
> 
> 
> 
> (2013/02/08 17:49), Atsushi Kumagai wrote:
> > Hello,
> > 
> > On Wed, 31 Oct 2012 23:05:05 +0900
> > Mitsuhiro Tanino <mitsuhiro.tanino.gm@xxxxxxxxxxx> wrote:
> > 
> >> This patch exports a PG_hwpoison into vmcoreinfo when
> >> CONFIG_MEMORY_FAILURE is defined.
> >> "makedumpfile" needs to read information of memory, such as
> >> 'mem_section', 'zone', 'pageflags' from vmcore.
> >>
> >> We introduce a function into "makedumpfile" to exclude
> >> hwpoison page from vmcore dump.
> >> In order to introduce this function, PG_hwpoison flag have
> >> to export into vmcoreinfo.
> >>
> >> Signed-off-by: Mitsuhiro Tanino <mitsuhiro.tanino.gm@xxxxxxxxxxx>
> > 
> > I'm curious to know the status of this patch because I'll release
> > makedumpfile-1.5.2 with the feature to exclude hwpoison page soon.
> > 
> > 
> > Thanks
> > Atsushi Kumagai
> > 
> >> ---
> >>  kernel/kexec.c |    3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/kernel/kexec.c b/kernel/kexec.c
> >> index 0668d58..0d5d6bc 100644
> >> --- a/kernel/kexec.c
> >> +++ b/kernel/kexec.c
> >> @@ -1513,6 +1513,9 @@ static int __init crash_save_vmcoreinfo_init(void)
> >>         VMCOREINFO_NUMBER(PG_lru);
> >>         VMCOREINFO_NUMBER(PG_private);
> >>         VMCOREINFO_NUMBER(PG_swapcache);
> >> +#ifdef CONFIG_MEMORY_FAILURE
> >> +       VMCOREINFO_NUMBER(PG_hwpoison);
> >> +#endif
> >>
> >>         arch_crash_save_vmcoreinfo();
> >>         update_vmcoreinfo_note();
> >> --
> >> 1.7.10.1
> >>
> >> _______________________________________________
> >> kexec mailing list
> >> kexec@xxxxxxxxxxxxxxxxxxx
> >> http://lists.infradead.org/mailman/listinfo/kexec
> > 
> > _______________________________________________
> > kexec mailing list
> > kexec@xxxxxxxxxxxxxxxxxxx
> > http://lists.infradead.org/mailman/listinfo/kexec
> > .
> > 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/