Re: [PATCH 07/11] ARM: integrator: fix build with INTEGRATOR_AP off

From: Linus Walleij
Date: Fri Feb 15 2013 - 04:13:57 EST

On Thu, Feb 14, 2013 at 2:49 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:

> The conditional declaration of ap_uart_data is broken
> and causes this build error:
> In file included from arch/arm/mach-integrator/core.c:35:0:
> arch/arm/mach-integrator/common.h:6:37: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
> Turning the check into an constant-expression if(IS_ENABLED()) statement
> creates more readable code and solves this problem as well.
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Russell King <linux@xxxxxxxxxxxxxxxx>

Brilliant Arnd, thanks for fixing this!

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at