Re: [RESEND] [PATCH] kernel/res_counter.c: remove useless returnstatement at res_counter_member()

From: Andrew Morton
Date: Thu Feb 14 2013 - 18:21:28 EST


On Sat, 02 Feb 2013 13:04:52 +0800
Jeff Liu <jeff.liu@xxxxxxxxxx> wrote:

> The return statement after BUG() is invalid, move BUG() to the default choice of the switch.
>
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
> ---
> kernel/res_counter.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/res_counter.c b/kernel/res_counter.c
> index ff55247..748a3bc 100644
> --- a/kernel/res_counter.c
> +++ b/kernel/res_counter.c
> @@ -135,10 +135,9 @@ res_counter_member(struct res_counter *counter, int member)
> return &counter->failcnt;
> case RES_SOFT_LIMIT:
> return &counter->soft_limit;
> + default:
> + BUG();
> };
> -
> - BUG();
> - return NULL;
> }
>
> ssize_t res_counter_read(struct res_counter *counter, int member,

I expect it was done that way to avoid a hey-theres-no-return-statement
warning when CONFIG_BUG=n.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/