Re: [PATCH 1/2] regmap: debugfs: Add a registers `range' file

From: Mark Brown
Date: Thu Feb 14 2013 - 09:43:14 EST


On Thu, Feb 14, 2013 at 12:31:44PM +0000, Dimitris Papastamos wrote:

> @@ -96,6 +116,7 @@ static unsigned int regmap_debugfs_get_dump_start(struct regmap *map,
> if (c) {
> c->max = p - 1;
> c->max_reg = i - 1;
> + c->reg_attr = regmap_attr_bitmap(map, c->max_reg);
> list_add_tail(&c->list,
> &map->debugfs_off_cache);
> c = NULL;

What happens if we have three registers like below?

X: read, write
X+1: read, write, volatile
X+2: read, write

It looks like we'll not flag X+1 as volatile, we'll just take the last
value we saw.

Attachment: signature.asc
Description: Digital signature