Re: [PATCH 2/2] regmap: irq: do not write mask register if it is notsupported

From: Mark Brown
Date: Thu Feb 14 2013 - 06:57:54 EST


On Thu, Feb 14, 2013 at 05:25:13PM +0530, Laxman Dewangan wrote:
> On Thursday 14 February 2013 05:05 PM, Mark Brown wrote:

> >This doesn't sound like something that should be open coded in
> >individual interrupt controller drivers, obviously it's a bit rubbish
> >that there's no way to enable or disable the interrupt but presumably
> >other hardware has the same "feature" and the IRQ subsystem ought to
> >understand it.

> To support such case, can we assume that mask is always enabled
> (interrupt enabled) so that it can be use in irq_thread to mask the
> interrupt status. So during initialization, if there is no mask_base
> register then all mask_buf is such that it enabled interrupt.

...and have any attempt to mask the interrupt return an error?

Attachment: signature.asc
Description: Digital signature