Re: [PATCH 1/1] VSOCK: Introduce VM Sockets

From: Gerd Hoffmann
Date: Thu Feb 14 2013 - 06:06:10 EST


On 02/07/13 01:23, Andy King wrote:
> + written = transport->stream_enqueue(
> + vsk, msg->msg_iov,
> + len - total_written);

Hmm, shouldn't we pass total_written to stream_enqueue here?

In case a blocking send(big-buffer) call gets splitted into multiple
stream_enqueue calls the second (and further) stream_enqueue calls need
to know at which msg offset they should continue sending the data, no?

cheers,
Gerd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/