Re: New Defect(s) reported by Coverity Scan

From: Borislav Petkov
Date: Wed Feb 13 2013 - 14:14:06 EST


On Wed, Feb 13, 2013 at 06:55:03PM +0000, Scan Subscription wrote:
> Hi Boris
>
> There is no fclose(file) call in parse_zoffset() function
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob_plain;f=arch/x86/boot/tools/build.c;hb=HEAD
>
> There is only one flcose call in this file and it is in the main() function
> Let us know if I am missing anything

Right, I was staring at older sources, sorry.

This parse_zoffset() thing has come in just recently with

commit 99f857db8857aff691c51302f93648263ed07eb1
Author: David Woodhouse <David.Woodhouse@xxxxxxxxx>
Date: Thu Jan 10 14:31:59 2013 +0000

x86, build: Dynamically find entry points in compressed startup code

and it might really need fclose() there for correctness' sake.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/