Re: [PATCH v2 5/9] pps: Move timestamp read into PPS code proper

From: Greg KH
Date: Wed Feb 13 2013 - 13:16:39 EST

On Tue, Feb 12, 2013 at 02:00:43AM -0500, George Spelvin wrote:
> The PPS (Pulse-Per-Second) line discipline has developed a number of
> unhealthy attachments to core tty data and functions, ultimately leading
> to its breakage.
> The previous patches fixed the crashing. This one reduces coupling further
> by eliminating the timestamp parameter from the dcd_change ldisc method.
> This reduces header file linkage and makes the extension more generic,
> and the timestamp read is delayed only slightly, from just before the
> ldisc->ops->dcd_change method call to just after.
> Fix attendant build breakage in
> drivers/tty/n_tty.c
> drivers/tty/tty_buffer.c
> drivers/staging/speakup/selection.c

I also had to fix up:

to get things to build properly.


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at